Unify utf8 file encoding and code style settings #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
axunonb
commented
Nov 5, 2024
•
axunonb
commented
- No changes in code logic
- Store files with utf8 encoding (set with .gitattributes, rewrite existing files)
- Update solution to file-scoped namespace
- Update .editorconfig and apply rules
* No changes in code logic * Store files with utf8 encoding (set with .gitattributes, rewrite existing files) * Update .editorconfig and apply rules
axunonb
force-pushed
the
pr/gitattributes-editorconfig
branch
from
d35b827
to
dfad131
Compare
|
|
@minichma If there's nothing against the 3 changes, I'd like to merge the PR, otherwise close and postpone. It's just standing in the way :) |
minichma
approved these changes
Nov 12, 2024
|
Sorry for the delay! I think its good to consistency throughout the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.